Bug 61845

Summary: Remove outer-spin-button
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, dglazkov, morrita, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Bug Depends on:    
Bug Blocks: 61415    
Attachments:
Description Flags
Patch
none
Patch for landing none

Kent Tamura
Reported 2011-06-01 01:27:47 PDT
Remove outer-spin-button because its layout code is too tricky, doesn't work correctly with padding and border, and hard to maintain.
Attachments
Patch (181.95 KB, patch)
2011-06-01 01:33 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (185.65 KB, patch)
2011-06-01 18:56 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-06-01 01:33:09 PDT
Created attachment 95562 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-06-01 09:34:01 PDT
Comment on attachment 95562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95562&action=review I think simpler is better, so I like this change. > LayoutTests/ChangeLog:13 > + * platform/mac/fast/forms/input-appearance-spinbutton-expected.png: The spin button looks a bit too close to the top. > Source/WebCore/ChangeLog:8 > + Remove outer-spin-button, and render steppers as inner-spin-button. I think you need to put a bit more explanation as to why here in the log.
Kent Tamura
Comment 3 2011-06-01 18:56:44 PDT
Created attachment 95700 [details] Patch for landing * Update ChangeLog * Clean SpinButtonElement too * Adjust NSStepper position
Kent Tamura
Comment 4 2011-06-02 00:04:21 PDT
Committed r87881: <http://trac.webkit.org/changeset/87881>
Kent Tamura
Comment 6 2011-06-09 02:59:58 PDT
(In reply to comment #5) > Maybe this fixed fast/forms/input-number-large-padding.html ? Yes, it's possible to fix it on Apple Mac and Chromium Mac. I'll confirm tomorrow.
Note You need to log in before you can comment on or make changes to this bug.