Bug 63448

Summary: [Qt] Remove Phonon MediaPlayer from the tree.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: WebKit QtAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, benjamin, hausmann, kenneth, kling, sam, vestbo, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch for landing none

Alexis Menard (darktears)
Reported 2011-06-27 06:26:43 PDT
[Qt] Remove Phonon MediaPlayer from the tree.
Attachments
Patch (30.03 KB, patch)
2011-06-27 07:01 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.10 KB, patch)
2011-06-27 10:07 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-06-27 07:01:41 PDT
Created attachment 98718 [details] Patch
Sam Weinig
Comment 2 2011-06-27 09:42:31 PDT
Not that object to removing things, but I am curious why? Is Phonon dead?
Kenneth Rohde Christiansen
Comment 3 2011-06-27 09:47:02 PDT
(In reply to comment #2) > Not that object to removing things, but I am curious why? Is Phonon dead? Phonon is deprecated within Qt (but still lives a life on its own as part of the KDE project). It also never worked properly for QtWebKit and noone is maintaining the current code. Our current path is using GStreamer directly on Linux, Quicktime on Mac (and Windows if available). For other cases we will be using QtMultimedia. This provides a better experience for our users and GStreamer is already the backend we are using on the Nokia N9.
Kenneth Rohde Christiansen
Comment 4 2011-06-27 09:48:22 PDT
Comment on attachment 98718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review > Source/WebKit/qt/docs/qtwebkit.qdocconf:167 > + K_DECLARE_PRIVATE K_? Sounds like some KDE thing, not related to Phonon?
Alexis Menard (darktears)
Comment 5 2011-06-27 10:03:32 PDT
(In reply to comment #4) > (From update of attachment 98718 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review > > > Source/WebKit/qt/docs/qtwebkit.qdocconf:167 > > + K_DECLARE_PRIVATE > > K_? Sounds like some KDE thing, not related to Phonon? May be, I'll remove it then.
Alexis Menard (darktears)
Comment 6 2011-06-27 10:04:47 PDT
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 98718 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review > > > > > Source/WebKit/qt/docs/qtwebkit.qdocconf:167 > > > + K_DECLARE_PRIVATE > > > > K_? Sounds like some KDE thing, not related to Phonon? > > May be, I'll remove it then. And will land it manually then, thanks for the review.
Alexis Menard (darktears)
Comment 7 2011-06-27 10:07:25 PDT
Created attachment 98742 [details] Patch for landing
WebKit Review Bot
Comment 8 2011-06-27 10:24:47 PDT
The commit-queue encountered the following flaky tests while processing attachment 98742 [details]: http/tests/local/fileapi/send-dragged-file.html bug 62791 (author: jianli@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 9 2011-06-27 10:26:45 PDT
Comment on attachment 98742 [details] Patch for landing Clearing flags on attachment: 98742 Committed r89832: <http://trac.webkit.org/changeset/89832>
WebKit Review Bot
Comment 10 2011-06-27 10:26:51 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 11 2011-06-27 11:15:27 PDT
Revision r89832 cherry-picked into qtwebkit-2.2 with commit 312ffd4 <http://gitorious.org/webkit/qtwebkit/commit/312ffd4>
Note You need to log in before you can comment on or make changes to this bug.