Bug 63914

Summary: SVGAnimateTransform does not support calcMode=discrete
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: martin.hejral, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64104    
Bug Blocks: 41761, 37250    
Attachments:
Description Flags
Patch rwlbuis: review+

Dirk Schulze
Reported 2011-07-04 11:20:19 PDT
SVGAnimateTransform does not support calcMode=discrete. I have a fix here, just unsure how to test. The animation testing API seems to be unstable for animateTransform. Sometimes the animation does not affect the transform of the target element.
Attachments
Patch (2.21 KB, patch)
2011-07-07 12:24 PDT, Dirk Schulze 		rwlbuis: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2011-07-07 10:02:28 PDT
Can't create a regression test, see bug 64104.
Dirk Schulze
Comment 2 2011-07-07 12:24:36 PDT
Created attachment 100017 [details] Patch
Rob Buis
Comment 3 2011-07-07 12:51:50 PDT
Comment on attachment 100017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100017&action=review Ok with some comments that you need to fix before landing. > Source/WebCore/ChangeLog:8 > + Apply transform at 0% of animation if current percentage is smaller than 0.5 and at 100% if not. Could be made more clear, you could start with Implement calcMode=discrete by... This sounds like a programmer speaking :) Try to incorporate the "This specifies that the animation function will jump from one value to the next without any interpolation." and why 0.5 was chosen. > Source/WebCore/ChangeLog:10 > + Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104. Could add the tracking bug for the animation framework problem. > Source/WebCore/manual-tests/svg-animateTransform-calcMode-discrete.svg:2 > +<text x="10" y="20">Testing calcMode="discrete" for &lt;animateTransform&gt;. The rect should move without an interpoalted translation after 2s.</text> interpoalted? Maybe reword a bit, maybe you can just use "jump" like in the spec definition.
Dirk Schulze
Comment 4 2011-07-07 13:17:22 PDT
Committed r90585: <http://trac.webkit.org/changeset/90585>
Note You need to log in before you can comment on or make changes to this bug.