Bug 64231

Summary: Generate conditional include statements in CodeGeneratorJS
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 64960, 64961, 65040    
Attachments:
Description Flags
Patch bfulgham: review+, paroga: commit-queue-

Patrick R. Gansterer
Reported 2011-07-09 10:45:48 PDT
Generate conditional include statements in CodeGeneratorJS
Attachments
Patch (4.76 KB, patch)
2011-07-09 11:04 PDT, Patrick R. Gansterer 		bfulgham: review+
paroga: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-07-09 11:04:30 PDT
Created attachment 100210 [details] Patch
Brent Fulgham
Comment 2 2011-07-10 18:57:31 PDT
Comment on attachment 100210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100210&action=review Great idea! I have a question (inline), but otherwise looks good. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2948 > + foreach my $include (sort keys %implIncludes) { We didn't sort these keys previously. Is the sorting just for legibility in the output? Or is it necessary to get proper function in generating the conditionalized output?
Patrick R. Gansterer
Comment 3 2011-07-10 22:08:33 PDT
Comment on attachment 100210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100210&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2948 >> + foreach my $include (sort keys %implIncludes) { > > We didn't sort these keys previously. Is the sorting just for legibility in the output? Or is it necessary to get proper function in generating the conditionalized output? Uhh, it's a relict of a temporary change. I'll remove it.
Patrick R. Gansterer
Comment 4 2011-07-10 22:20:17 PDT
Committed r90717: <http://trac.webkit.org/changeset/90717>
Note You need to log in before you can comment on or make changes to this bug.