Bug 65040

Summary: Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 64231    
Bug Blocks: 65050    
Attachments:
Description Flags
Patch bfulgham: review+, webkit.review.bot: commit-queue-

Patrick R. Gansterer
Reported 2011-07-22 12:32:45 PDT
Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
Attachments
Patch (9.38 KB, patch)
2011-07-22 12:49 PDT, Patrick R. Gansterer 		bfulgham: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-07-22 12:49:09 PDT
Created attachment 101755 [details] Patch
Brent Fulgham
Comment 2 2011-08-29 11:53:17 PDT
Comment on attachment 101755 [details] Patch This looks great!
WebKit Review Bot
Comment 3 2011-08-29 12:24:46 PDT
Comment on attachment 101755 [details] Patch Rejecting attachment 101755 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: set 37 lines). Hunk #4 succeeded at 2660 (offset 37 lines). Hunk #5 succeeded at 2697 (offset 37 lines). Hunk #6 succeeded at 2717 (offset 37 lines). Hunk #7 FAILED at 2691. Hunk #8 succeeded at 2782 (offset 37 lines). Hunk #9 succeeded at 2793 (offset 37 lines). 1 out of 9 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Brent Fulgham', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/9567158
Patrick R. Gansterer
Comment 4 2011-08-29 13:04:01 PDT
Committed r94005: <http://trac.webkit.org/changeset/94005>
Note You need to log in before you can comment on or make changes to this bug.