Bug 66173

Summary: [Qt] Add eventSender.gestureTap
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, gmak, ossy, sadrul, tonikitoo, webkit.review.bot, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 79359, 92895    
Bug Blocks:    
Attachments:
Description Flags
fix
none
Patch
none
Patch
none
Patch2 none

Ryosuke Niwa
Reported 2011-08-12 15:40:21 PDT
r92997 added new eventSender method: gestureTap. Qt should implement this feature.
Attachments
fix (1.87 KB, patch)
2011-08-12 15:46 PDT, Sadrul Habib Chowdhury 		no flags
DetailsFormatted DiffDiff
Patch (3.03 KB, patch)
2012-02-22 10:10 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (4.86 KB, patch)
2012-09-19 06:31 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch2 (12.80 KB, patch)
2012-09-21 08:02 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sadrul Habib Chowdhury
Comment 1 2011-08-12 15:46:09 PDT
Created attachment 103830 [details] fix
Sadrul Habib Chowdhury
Comment 2 2011-08-12 15:46:58 PDT
The fast/event/touch tests are already skipped in other platforms (e.g. win, mac, gtk)
Ryosuke Niwa
Comment 3 2011-08-12 15:47:37 PDT
Comment on attachment 103830 [details] fix I'm adding the test to the Qt's skipped list for now. This patch isn't going to fix this bug because it doesn't actually implement the eventSender method.
Ryosuke Niwa
Comment 4 2011-08-12 15:50:17 PDT
The test skipped in http://trac.webkit.org/changeset/93006.
Allan Sandfeld Jensen
Comment 5 2012-02-22 10:10:24 PST
Created attachment 128237 [details] Patch
WebKit Review Bot
Comment 6 2012-02-22 16:55:56 PST
Comment on attachment 128237 [details] Patch Clearing flags on attachment: 128237 Committed r108577: <http://trac.webkit.org/changeset/108577>
WebKit Review Bot
Comment 7 2012-02-22 16:56:00 PST
All reviewed patches have been landed. Closing bug.
Allan Sandfeld Jensen
Comment 8 2012-02-23 07:04:11 PST
The patch did not implement the tap gesture in a functional way, and I am not sure we want to implement it since it is completely absent from the WebKitTestRunner.
Allan Sandfeld Jensen
Comment 9 2012-09-19 06:31:05 PDT
Created attachment 164729 [details] Patch
WebKit Review Bot
Comment 10 2012-09-20 01:19:09 PDT
Comment on attachment 164729 [details] Patch Clearing flags on attachment: 164729 Committed r129102: <http://trac.webkit.org/changeset/129102>
WebKit Review Bot
Comment 11 2012-09-20 01:19:13 PDT
All reviewed patches have been landed. Closing bug.
Allan Sandfeld Jensen
Comment 12 2012-09-21 07:58:23 PDT
The implemenatation lacked handling of the GestureEvent in WebKit code. I missed this for the second time, because the default expected result of the test-case is actually a fail.
Allan Sandfeld Jensen
Comment 13 2012-09-21 08:02:03 PDT
Created attachment 165132 [details] Patch2
WebKit Review Bot
Comment 14 2012-09-21 08:05:46 PDT
Attachment 165132 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/qt/Api/qwebpage.cpp:98: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/qt/Api/qwebpage.cpp:136: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Hausmann
Comment 15 2012-10-21 23:39:52 PDT
Comment on attachment 165132 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=165132&action=review r=me but needs #include order fix before landing I suppose :) > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:322 > + m_position = event->widget()->mapFromGlobal(globalPos.toPoint()); With the upcoming QtWebKit <> QtWebKitWidgets split in mind it would be great if the widget local position could be provided as a parameter from outside to reduce the amount of widget code here :)
Allan Sandfeld Jensen
Comment 16 2012-10-22 02:38:25 PDT
(In reply to comment #15) > (From update of attachment 165132 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165132&action=review > > r=me but needs #include order fix before landing I suppose :) > > > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:322 > > + m_position = event->widget()->mapFromGlobal(globalPos.toPoint()); > > With the upcoming QtWebKit <> QtWebKitWidgets split in mind it would be great if the widget local position could be provided as a parameter from outside to reduce the amount of widget code here :) But wouldn't QtWebKit(1) be in QtWebKitWidgets, and therefore allowed to depend on Widget code?
Allan Sandfeld Jensen
Comment 17 2012-10-22 04:53:59 PDT
Committed in r132052
Allan Sandfeld Jensen
Comment 18 2012-10-22 04:54:20 PDT
Comment on attachment 165132 [details] Patch2 Clearing flags
Note You need to log in before you can comment on or make changes to this bug.