Bug 67090

Summary: SQLiteStatement::getColumnText() could construct WTF::String result more efficiently.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2011-08-27 07:15:55 PDT
Instead of using the WTF::String(const UChar*) constructor and traversing the string to determine the length, we should use sqlite3_column_bytes16() .
Attachments
Proposed patch (1.42 KB, patch)
2011-08-27 07:18 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-08-27 07:18:31 PDT
Created attachment 105437 [details] Proposed patch
Benjamin Poulain
Comment 2 2011-08-27 09:37:50 PDT
How much improvement?
Andreas Kling
Comment 3 2011-08-27 09:44:19 PDT
(In reply to comment #2) > How much improvement? Over 9000.
Andreas Kling
Comment 4 2011-08-27 10:11:23 PDT
(In reply to comment #3) > (In reply to comment #2) > > How much improvement? > > Over 9000. To clarify, I just spoke with Benjamin about this, he's concerned that the additional mutex lock (happens implicitly with any sqlite3 call) would negate any gains from avoiding the string traversal.
WebKit Review Bot
Comment 5 2011-08-27 14:12:37 PDT
Comment on attachment 105437 [details] Proposed patch Clearing flags on attachment: 105437 Committed r93945: <http://trac.webkit.org/changeset/93945>
WebKit Review Bot
Comment 6 2011-08-27 14:12:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.