Bug 67718

Summary: <style scoped>: Add 'scoped' attribute
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: DOMAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, dglazkov, dominicc, hayato, hyatt, koivisto, morrita, ojan, webkit.org, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 67796, 67811    
Bug Blocks: 49142, 67790    
Attachments:
Description Flags
Patch
none
patch with flag none

Roland Steiner
Reported 2011-09-07 11:08:41 PDT
As part of the larger <style scoped> implementation, implement the necessary changes to the DOM and HTML classes.
Attachments
Patch (12.17 KB, patch)
2011-09-08 10:56 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
patch with flag (16.96 KB, patch)
2011-12-04 22:51 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-09-08 10:56:43 PDT
Created attachment 106763 [details] Patch The patch adds the 'scoped' attribute to the HTMLStyleElement IDL and HTMLAttributeNames.in, and tests setting and re-setting the attribute in various circumstances.
Roland Steiner
Comment 2 2011-09-08 12:55:39 PDT
Committed r94784: <http://trac.webkit.org/changeset/94784>
Roland Steiner
Comment 3 2011-09-08 13:36:32 PDT
Rolled out in r106777 in order to allow for more discussion
WebKit Review Bot
Comment 4 2011-09-08 15:16:41 PDT
Comment on attachment 106763 [details] Patch Clearing flags on attachment: 106763 Committed r94809: <http://trac.webkit.org/changeset/94809>
WebKit Review Bot
Comment 5 2011-09-08 15:16:45 PDT
All reviewed patches have been landed. Closing bug.
Roland Steiner
Comment 6 2011-09-08 15:44:25 PDT
Reverted r94809 for reason: commit _still_ premature, despite CQ eagerness Committed r94813: <http://trac.webkit.org/changeset/94813>
Dimitri Glazkov (Google)
Comment 7 2011-11-18 07:33:21 PST
Do we need an ENABLE flag for this, at least while the implementation is incomplete?
Roland Steiner
Comment 8 2011-11-20 22:04:24 PST
Opened a new bug https://bugs.webkit.org/show_bug.cgi?id=72848 for the ENABLE flag.
Roland Steiner
Comment 9 2011-11-21 00:41:22 PST
A question is, do we need to add the flag to code that handles the attribute/property, but has no outside side effects? I.e: - attribute reflection code - registration with parent element - window.internals.numberOfScopedHTMLStyleChildren function
Dimitri Glazkov (Google)
Comment 10 2011-11-21 09:03:29 PST
(In reply to comment #9) > A question is, do we need to add the flag to code that handles the attribute/property, but has no outside side effects? I.e: > > - attribute reflection code > - registration with parent element > - window.internals.numberOfScopedHTMLStyleChildren function Yes. One of the uses of the flag is to remove a feature in case it is unstable, and that wouldn't work if we only limited the flag to the author-visible effects.
Roland Steiner
Comment 11 2011-11-22 00:16:30 PST
(In reply to comment #10) > Yes. One of the uses of the flag is to remove a feature in case it is unstable, and that wouldn't work if we only limited the flag to the author-visible effects. In that case, how do I best handle the addition/changes to HTMLAttributeNames.in and HTMLStyleElement.idl?
Dimitri Glazkov (Google)
Comment 12 2011-11-22 09:35:42 PST
(In reply to comment #11) > (In reply to comment #10) > > Yes. One of the uses of the flag is to remove a feature in case it is unstable, and that wouldn't work if we only limited the flag to the author-visible effects. > > In that case, how do I best handle the addition/changes to HTMLAttributeNames.in and HTMLStyleElement.idl? 1) Add item to HTMLAttributeNames.in 2) Add conditional attribute to HTMLStyleElement.idl In other words, follow existing conventions.
Roland Steiner
Comment 13 2011-12-04 22:51:51 PST
Created attachment 117846 [details] patch with flag Same patch as before, with added ENABLE(STYLE_SCOPED) flag
WebKit Review Bot
Comment 14 2011-12-05 03:48:46 PST
Comment on attachment 117846 [details] patch with flag Clearing flags on attachment: 117846 Committed r101987: <http://trac.webkit.org/changeset/101987>
WebKit Review Bot
Comment 15 2011-12-05 03:48:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.