Bug 69829

Summary: Implement a WebKitTransitionEvent constructor for JSC
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, rniwa, sam, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67824    
Attachments:
Description Flags
Patch
simon.fraser: review+
rebased patch for commit
none
rebased patch for commit webkit.review.bot: commit-queue-

Kentaro Hara
Reported 2011-10-11 03:42:35 PDT
We have been implementing constructors of Events. WebKitTransitionEvent should have a constructor. There is no spec for the WebKitTransitionEvent constructor, since it is WebKit-specific. Judging from the current IDL of initWebKitTransitionEvent(), the IDL of the WebKitTransitionEvent constructor should be as follows. [Constructor(DOMString type, optional WebKitTransitionEventInit eventInitDict)] interface WebKitTransitionEvent : Event { ...; } dictionary WebKitTransitionEventInit : EventInit { DOMString propertyName; double elapsedTime; }
Attachments
Patch (23.56 KB, patch)
2011-10-11 04:08 PDT, Kentaro Hara 		simon.fraser: review+
DetailsFormatted DiffDiff
rebased patch for commit (23.53 KB, patch)
2011-10-11 18:31 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (23.53 KB, patch)
2011-10-11 20:55 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-10-11 04:08:22 PDT
Created attachment 110496 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-10-11 11:59:50 PDT
Please do the animation events at the same time.
Kentaro Hara
Comment 3 2011-10-11 17:57:40 PDT
(In reply to comment #2) > Please do the animation events at the same time. Constructor for WebKitAnimationEvent is already on trunk both for JSC and for V8. (bug 67825 and bug 67922). Or, do you mean that we need more test cases where WebKitAnimationEvent and WebKitAnimationEvent are used at the same time (like animations/transition-and-animation-*.html)?
Simon Fraser (smfr)
Comment 4 2011-10-11 18:05:00 PDT
(In reply to comment #3) > (In reply to comment #2) > > Please do the animation events at the same time. > > Constructor for WebKitAnimationEvent is already on trunk both for JSC and for V8. (bug 67825 and bug 67922). Ah, I didn't realize they were done.
Simon Fraser (smfr)
Comment 5 2011-10-11 18:26:23 PDT
Comment on attachment 110496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110496&action=review > Source/WebCore/dom/WebKitTransitionEvent.cpp:35 > + , elapsedTime(0.0) Just use 0, not 0.0
Kentaro Hara
Comment 6 2011-10-11 18:31:24 PDT
Created attachment 110627 [details] rebased patch for commit
WebKit Review Bot
Comment 7 2011-10-11 19:38:37 PDT
Comment on attachment 110627 [details] rebased patch for commit Rejecting attachment 110627 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: 4ffd39561b4144c727ef44bdcacdff4e49fffb1b r97219 = 2d6bddd541d82ee7ac8dfd329feb66e56e81c258 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10030741
Adam Barth
Comment 8 2011-10-11 20:27:39 PDT
Comment on attachment 110627 [details] rebased patch for commit If the review flag isn't set, you need to fill out the reviewer In the changelog.
Kentaro Hara
Comment 9 2011-10-11 20:55:45 PDT
Created attachment 110630 [details] rebased patch for commit
Kentaro Hara
Comment 10 2011-10-11 20:57:55 PDT
(In reply to comment #8) > (From update of attachment 110627 [details]) > If the review flag isn't set, you need to fill out the reviewer In the changelog. Ah, thank you for letting me know!
WebKit Review Bot
Comment 11 2011-10-11 21:04:19 PDT
Comment on attachment 110627 [details] rebased patch for commit Clearing flags on attachment: 110627 Committed r97225: <http://trac.webkit.org/changeset/97225>
WebKit Review Bot
Comment 12 2011-10-11 21:11:18 PDT
Comment on attachment 110630 [details] rebased patch for commit Rejecting attachment 110630 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 13bfc3c27b3ef9b9dbaaef33caa8673d70b81b81 r97225 = 9dbc3f5be8d6a8831e5a895939bfd3c36d7076d0 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10031656
Ryosuke Niwa
Comment 13 2011-10-11 23:10:40 PDT
Rebaseline done in http://trac.webkit.org/changeset/97236.
Note You need to log in before you can comment on or make changes to this bug.