Bug 69907

Summary: Implement an OverflowEvent constructor for JSC
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dglazkov, dominicc, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67824    
Attachments:
Description Flags
Patch
none
Patch
abarth: review+
rebased patch for commit none

Kentaro Hara
Reported 2011-10-12 00:01:57 PDT
We have been implementing constructors of Events. OverflowEvent should have a constructor. There is no spec for the OverflowEvent constructor, since it is WebKit-specific. Judging from the current IDL of initOverflowEvent(), the IDL of the OveflowEvent constructor should be as follows. [Constructor(DOMString type, optional OverflowEventInit eventInitDict)] interface OverflowEvent : Event { ...; } dictionary OverflowEventInit : EventInit { unsigned short orient; boolean horizontalOverflow; boolean verticalOverflow; }
Attachments
Patch (20.84 KB, patch)
2011-10-12 00:59 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (22.56 KB, patch)
2011-10-12 07:18 PDT, Kentaro Hara 		abarth: review+
DetailsFormatted DiffDiff
rebased patch for commit (22.75 KB, patch)
2011-10-13 00:56 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-10-12 00:59:04 PDT
Created attachment 110650 [details] Patch
WebKit Review Bot
Comment 2 2011-10-12 03:29:09 PDT
Comment on attachment 110650 [details] Patch Attachment 110650 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10032646 New failing tests: fast/dom/dom-constructors.html
Kentaro Hara
Comment 3 2011-10-12 07:18:43 PDT
Created attachment 110682 [details] Patch
Adam Barth
Comment 4 2011-10-12 09:49:36 PDT
Comment on attachment 110682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110682&action=review > Source/WebCore/dom/OverflowEvent.idl:26 > */ > module events { > - interface OverflowEvent : Event { > + interface [ We could add some blank lines between the license block, the module, and the interface declaration. (If you wanted to.)
Kentaro Hara
Comment 5 2011-10-13 00:56:53 PDT
Created attachment 110808 [details] rebased patch for commit
WebKit Review Bot
Comment 6 2011-10-13 02:12:55 PDT
Comment on attachment 110808 [details] rebased patch for commit Clearing flags on attachment: 110808 Committed r97356: <http://trac.webkit.org/changeset/97356>
Note You need to log in before you can comment on or make changes to this bug.