Bug 71534

Summary: [V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: WebCore Misc.Assignee: Dmitry Lomov <dslomov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66578    
Attachments:
Description Flags
Fix
none
Style nit
levin: review+, levin: commit-queue-
Removed OOPS none

Dmitry Lomov
Reported 2011-11-03 19:58:38 PDT
V8 optimizes accesses to typed array views. When array views are neutered, relevant code should be regerenerated
Attachments
Fix (8.53 KB, patch)
2011-11-07 15:57 PST, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Style nit (8.35 KB, patch)
2011-11-07 15:59 PST, Dmitry Lomov 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
Removed OOPS (8.29 KB, patch)
2011-11-07 16:20 PST, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-11-07 15:57:42 PST
Created attachment 113945 [details] Fix
Dmitry Lomov
Comment 2 2011-11-07 15:59:35 PST
Created attachment 113947 [details] Style nit
David Levin
Comment 3 2011-11-07 16:15:43 PST
Adam, do we need to change the test idl to verify this idl change?
David Levin
Comment 4 2011-11-07 16:15:58 PST
(In reply to comment #3) > Adam, do we need to change the test idl to verify this idl change? I meant generator change.
Adam Barth
Comment 5 2011-11-07 16:17:05 PST
You can if you like, but it's not required.
David Levin
Comment 6 2011-11-07 16:18:22 PST
Comment on attachment 113947 [details] Style nit Seems fine. I'm not sure that a change to the test idl bindings would add any value so I'll leave that to your discretion.
David Levin
Comment 7 2011-11-07 16:18:54 PST
Comment on attachment 113947 [details] Style nit Need to remove first oops.
Dmitry Lomov
Comment 8 2011-11-07 16:20:33 PST
Created attachment 113949 [details] Removed OOPS
WebKit Review Bot
Comment 9 2011-11-07 16:59:49 PST
Comment on attachment 113949 [details] Removed OOPS Clearing flags on attachment: 113949 Committed r99507: <http://trac.webkit.org/changeset/99507>
WebKit Review Bot
Comment 10 2011-11-07 16:59:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.