Bug 72785

Summary: Move gamepad to Modules/ (+ some cleanup)
Product: WebKit Reporter: Scott Graham <scottmg>
Component: WebCore Misc.Assignee: Scott Graham <scottmg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Scott Graham
Reported 2011-11-18 18:34:10 PST
Based on discussion here: https://bugs.webkit.org/show_bug.cgi?id=71753 Some gamepad cleanup: - use fast/js/ test harness - add #if ENABLE around headers in Navigator to avoid including them for ports that aren't using them - move from page/ to new Modules/ location
Attachments
Patch (36.42 KB, patch)
2011-11-18 19:09 PST, Scott Graham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Scott Graham
Comment 1 2011-11-18 19:09:57 PST
Created attachment 115924 [details] Patch
Adam Barth
Comment 2 2011-11-18 19:23:17 PST
Comment on attachment 115924 [details] Patch Looks great. Thanks!
WebKit Review Bot
Comment 3 2011-11-19 12:51:59 PST
Comment on attachment 115924 [details] Patch Clearing flags on attachment: 115924 Committed r100860: <http://trac.webkit.org/changeset/100860>
WebKit Review Bot
Comment 4 2011-11-19 12:52:05 PST
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 5 2011-11-19 19:48:18 PST
This patch added (or rather moved I guess) a bunch of files with license headers that use C++ style comments rather than C-style, which is out of the norm.
Adam Barth
Comment 6 2011-11-19 21:51:51 PST
Thanks Sam. Scott, would you be willing to update the license headers to match the common style in WebKit? I presume you copied the license headers from somewhere. Do you remember where so we can align them with the norm as well?
Scott Graham
Comment 7 2011-11-21 09:28:40 PST
https://bugs.webkit.org/show_bug.cgi?id=72894 (sorry, not a committer so I'll have to get you to do it) I believe I copied the license from mail from mal@ so the comment style was probably my own "innovation" (i.e. other places may be fine).
Note You need to log in before you can comment on or make changes to this bug.