Bug 76827

Summary: Eliminate CSSElementStyleDeclaration subclasses
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch kling: review+, gyuyoung.kim: commit-queue-

Antti Koivisto
Reported 2012-01-23 07:11:59 PST
CSSInlineStyleDeclaration and FontFaceStyleDeclaration serve no purpose.
Attachments
patch (24.45 KB, patch)
2012-01-23 08:41 PST, Antti Koivisto 		kling: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-01-23 08:41:32 PST
Created attachment 123564 [details] patch
WebKit Review Bot
Comment 2 2012-01-23 08:44:11 PST
Attachment 123564 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSElementStyleDeclaration.h:40: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2012-01-23 08:46:34 PST
Comment on attachment 123564 [details] patch Oh god make it go away. r=me
Antti Koivisto
Comment 4 2012-01-23 08:49:56 PST
http://trac.webkit.org/changeset/105630
Csaba Osztrogonác
Comment 5 2012-01-23 09:03:09 PST
It broke the (Qt) build: ../../../../Source/WebCore/css/CSSElementStyleDeclaration.cpp: In static member function ‘static WTF::PassRefPtr<WebCore::CSSElementStyleDeclaration> WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement(WebCore::SVGFontFaceElement*)’: ../../../../Source/WebCore/css/CSSElementStyleDeclaration.cpp:36: error: no matching function for call to ‘WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration(WebCore::SVGFontFaceElement*&, bool)’ ../../../../Source/WebCore/css/CSSElementStyleDeclaration.h:48: note: candidates are: WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration(WebCore::StyledElement*, bool) ../../../../Source/WebCore/css/CSSElementStyleDeclaration.h:37: note: WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration(const WebCore::CSSElementStyleDeclaration&) Could you guys fix it?
Gyuyoung Kim
Comment 6 2012-01-23 09:10:43 PST
Comment on attachment 123564 [details] patch Attachment 123564 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11284675
Antti Koivisto
Comment 7 2012-01-23 09:43:10 PST
Fixed SVG_FONTS=0 build in http://trac.webkit.org/changeset/105632
Note You need to log in before you can comment on or make changes to this bug.