Bug 79293

Summary: Enable Geolocation bindings for GObject
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, haraken, mrobinson, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79327    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2012-02-22 16:05:26 PST
Enable Geolocation bindings for GObject
Attachments
Patch (1.35 KB, patch)
2012-02-22 16:06 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (5.49 KB, patch)
2012-02-22 20:56 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-02-22 16:06:05 PST
Created attachment 128316 [details] Patch
Kentaro Hara
Comment 2 2012-02-22 16:09:47 PST
Try to see if the GTK bot gets happy.
Philippe Normand
Comment 3 2012-02-22 16:31:36 PST
Comment on attachment 128316 [details] Patch Attachment 128316 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11599019
Kentaro Hara
Comment 4 2012-02-22 16:32:18 PST
:-(
Adam Barth
Comment 5 2012-02-22 16:35:37 PST
Comment on attachment 128316 [details] Patch I'm not sure it's the same problem that mrobinson fixed. It might just be a bug somewhere in the code generator where the include line isn't being generated for some reason.
Martin Robinson
Comment 6 2012-02-22 17:38:41 PST
This failure seems unrelated to the bug I was looking at.
Martin Robinson
Comment 7 2012-02-22 17:40:18 PST
Do take care when making changes that break API on GTK+. We just branched for a stable release a few days ago and if Geolocation was disabled there, we may have shipped a pre-release with an API break.
Adam Barth
Comment 8 2012-02-22 17:44:00 PST
Hopefully we will get this fixed shortly. The breaking half of this change when in less than 24 hours ago. With any luck, we'll resolve the issue within another 24 hours.
Martin Robinson
Comment 9 2012-02-22 17:48:04 PST
(In reply to comment #8) > Hopefully we will get this fixed shortly. The breaking half of this change when in less than 24 hours ago. With any luck, we'll resolve the issue within another 24 hours. If it was only 24-hours ago, everything should be fine then. We branched before that point. :)
Kentaro Hara
Comment 10 2012-02-22 20:48:50 PST
I tried the GTK build in my local machine and found that "WebCore::" is missing before "NavigatorGeolocation":-) Patch is coming.
Kentaro Hara
Comment 11 2012-02-22 20:56:19 PST
Created attachment 128381 [details] Patch
Kentaro Hara
Comment 12 2012-02-22 21:05:20 PST
The GTK bot looks happy:)
Adam Barth
Comment 13 2012-02-22 21:41:41 PST
Comment on attachment 128381 [details] Patch Ah!
WebKit Review Bot
Comment 14 2012-02-22 22:25:54 PST
Comment on attachment 128381 [details] Patch Clearing flags on attachment: 128381 Committed r108610: <http://trac.webkit.org/changeset/108610>
WebKit Review Bot
Comment 15 2012-02-22 22:25:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.