Bug 82403

Summary:

Add missing methods and operators to FractionalLayoutUnit

Product:

WebKit

Reporter:

Emil A Eklund <eae>

Component:

Layout and Rendering

Assignee:

Emil A Eklund <eae>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, gustavo, leviw, lforschler, pnormand, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

60318

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Emil A Eklund

Reported 2012-03-27 17:37:26 PDT

Add missing operators and constructors to FractionalLayoutUnit.

Attachments
Patch (5.21 KB, patch) 2012-03-28 08:45 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch (5.03 KB, patch) 2012-03-28 11:50 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch (4.71 KB, patch) 2012-04-05 18:16 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch (3.78 KB, patch) 2012-04-09 10:50 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Emil A Eklund

Comment 1 2012-03-28 08:45:54 PDT

Created attachment 134304 [details] Patch

WebKit Review Bot

Comment 2 2012-03-28 08:52:51 PDT

Attachment 134304 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/FractionalLayoutUnit.h:82: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2012-03-28 09:07:38 PDT

Comment on attachment 134304 [details] Patch Attachment 134304 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12153242

Build Bot

Comment 4 2012-03-28 09:09:33 PDT

Comment on attachment 134304 [details] Patch Attachment 134304 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12153246

Early Warning System Bot

Comment 5 2012-03-28 09:13:49 PDT

Comment on attachment 134304 [details] Patch Attachment 134304 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12159101

Emil A Eklund

Comment 6 2012-03-28 11:50:46 PDT

Created attachment 134356 [details] Patch

WebKit Review Bot

Comment 7 2012-03-28 11:56:59 PDT

Attachment 134356 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/FractionalLayoutUnit.h:81: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Philippe Normand

Comment 8 2012-03-28 12:11:18 PDT

Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12152338

Build Bot

Comment 9 2012-03-28 12:37:58 PDT

Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12152353

Early Warning System Bot

Comment 10 2012-03-28 13:18:29 PDT

Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12153413

Emil A Eklund

Comment 11 2012-03-28 13:22:08 PDT

Argh, sorry about all the spam, please ignore this bug for now.

Early Warning System Bot

Comment 12 2012-03-28 13:35:48 PDT

Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12156290

WebKit Review Bot

Comment 13 2012-03-28 13:48:46 PDT

Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12152387

Emil A Eklund

Comment 14 2012-04-05 18:16:10 PDT

Created attachment 135957 [details] Patch

WebKit Review Bot

Comment 15 2012-04-05 18:20:17 PDT

Attachment 135957 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/FractionalLayoutUnit.h:81: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 16 2012-04-05 19:57:24 PDT

Comment on attachment 135957 [details] Patch Attachment 135957 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12337629

Early Warning System Bot

Comment 17 2012-04-05 20:09:57 PDT

Comment on attachment 135957 [details] Patch Attachment 135957 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12336709

Eric Seidel (no email)

Comment 18 2012-04-06 10:19:16 PDT

Unhappy ewses.

Build Bot

Comment 19 2012-04-06 19:08:11 PDT

Comment on attachment 135957 [details] Patch Attachment 135957 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12343011

Emil A Eklund

Comment 20 2012-04-09 10:50:08 PDT

Created attachment 136265 [details] Patch

WebKit Review Bot

Comment 21 2012-04-09 10:53:24 PDT

Attachment 136265 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/FractionalLayoutUnit.h:81: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Emil A Eklund

Comment 22 2012-04-09 12:01:05 PDT

The style ews failure is expected (wtf_ceil) but the others seem happy now at least.

Emil A Eklund

Comment 23 2012-04-09 19:03:14 PDT

Can haz review?

Eric Seidel (no email)

Comment 24 2012-04-09 19:34:07 PDT

Comment on attachment 136265 [details] Patch OK.

WebKit Review Bot

Comment 25 2012-04-10 10:11:30 PDT

Comment on attachment 136265 [details] Patch Clearing flags on attachment: 136265 Committed r113730: <http://trac.webkit.org/changeset/113730>

WebKit Review Bot

Comment 26 2012-04-10 10:11:36 PDT

All reviewed patches have been landed. Closing bug.

Lucas Forschler

Comment 27 2012-04-13 11:03:06 PDT

This check in causes a 20% decrease in performance for the Mac Lion dromeo test http://webkit-perf.appspot.com/graph.html#tests=[[33030,2001,32196]]&sel=none&displayrange=7&datatype=running

Levi Weintraub

Comment 28 2012-04-13 11:05:26 PDT

(In reply to comment #27) > This check in causes a 20% decrease in performance for the Mac Lion dromeo test > http://webkit-perf.appspot.com/graph.html#tests=[[33030,2001,32196]]&sel=none&displayrange=7&datatype=running I don't think this is the cause of that regression... None of this code is in use yet.

Lucas Forschler

Comment 29 2012-04-13 11:07:41 PDT

Ah, the test results are not atomic. The regression happened somewhere between 113608 and 113730.

Levi Weintraub

Comment 30 2012-04-13 11:13:33 PDT

(In reply to comment #29) > Ah, the test results are not atomic. The regression happened somewhere between 113608 and 113730. That'd explain it :) Here's a handy link: http://trac.webkit.org/log/?action=stop_on_copy&mode=stop_on_copy&rev=113730&stop_rev=113608&limit=200

Note You need to log in before you can comment on or make changes to this bug.