Bug 83612

Summary:

Split CSSStyleSheet into internal and CSSOM type

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric.carlson, feature-media-reviews, kling, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

77745

Attachments:

Description	Flags
patch	webkit-ews: commit-queue-
rebased	webkit.review.bot: commit-queue-
try to fix chromium build	webkit.review.bot: commit-queue-
resubmitting for bots	kling: review-
try to fix chromium build	none
fix a crashing test	kling: review+

Antti Koivisto

Reported 2012-04-10 13:23:08 PDT

This will complete the separation of our style sheet data structures from CSSOM.

Attachments
patch (116.48 KB, patch) 2012-04-10 18:06 PDT, Antti Koivisto	webkit-ews: commit-queue-	Details Formatted Diff Diff
rebased (117.61 KB, patch) 2012-04-11 07:27 PDT, Antti Koivisto	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
try to fix chromium build (117.91 KB, patch) 2012-04-11 08:12 PDT, Antti Koivisto	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
resubmitting for bots (117.91 KB, patch) 2012-04-11 11:05 PDT, Antti Koivisto	kling: review-	Details Formatted Diff Diff
try to fix chromium build (119.63 KB, patch) 2012-04-11 13:38 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
fix a crashing test (121.37 KB, patch) 2012-04-11 16:11 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2012-04-10 18:06:47 PDT

Created attachment 136592 [details] patch

WebKit Review Bot

Comment 2 2012-04-10 18:10:49 PDT

Attachment 136592 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.h:73: The parameter name "ruleRangeMap" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/css/CSSParser.h:81: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSParser.cpp:1025: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSStyleSheet.h:135: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSStyleSheet.h:135: The parameter name "rule" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/css/CSSStyleSheet.h:183: The parameter name "b" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/css/CSSStyleSheet.cpp:174: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 7 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2012-04-10 19:29:18 PDT

Comment on attachment 136592 [details] patch Attachment 136592 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12386129

Early Warning System Bot

Comment 4 2012-04-10 19:35:27 PDT

Comment on attachment 136592 [details] patch Attachment 136592 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12380651

WebKit Review Bot

Comment 5 2012-04-10 22:42:09 PDT

Comment on attachment 136592 [details] patch Attachment 136592 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12380718

Antti Koivisto

Comment 6 2012-04-11 07:27:44 PDT

Created attachment 136666 [details] rebased

WebKit Review Bot

Comment 7 2012-04-11 07:29:37 PDT

Attachment 136666 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.h:81: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSParser.cpp:1025: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 8 2012-04-11 08:01:43 PDT

Comment on attachment 136666 [details] rebased Attachment 136666 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12387070

Antti Koivisto

Comment 9 2012-04-11 08:12:57 PDT

Created attachment 136670 [details] try to fix chromium build

WebKit Review Bot

Comment 10 2012-04-11 08:16:47 PDT

Attachment 136670 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.h:81: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSParser.cpp:1025: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 11 2012-04-11 08:45:00 PDT

Comment on attachment 136670 [details] try to fix chromium build Attachment 136670 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12380927

Antti Koivisto

Comment 12 2012-04-11 09:40:04 PDT

It looks like V8 bindings are using WebCore::StyleSheetInternal as a namespace name :(

Antti Koivisto

Comment 13 2012-04-11 11:03:56 PDT

The name collision was fixed in http://trac.webkit.org/changeset/113881

Antti Koivisto

Comment 14 2012-04-11 11:05:54 PDT

Created attachment 136708 [details] resubmitting for bots

WebKit Review Bot

Comment 15 2012-04-11 11:10:33 PDT

Attachment 136708 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.h:81: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSParser.cpp:1025: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 16 2012-04-11 12:07:57 PDT

Comment on attachment 136708 [details] resubmitting for bots View in context: https://bugs.webkit.org/attachment.cgi?id=136670&action=review > Source/WebCore/css/CSSStyleSheet.cpp:510 > + m_childRuleCSSOMWrappers[index]->setParentStyleSheet(0); We're gonna need a null check here, since this particular wrapper may not have been instantiated. > Source/WebCore/dom/ProcessingInstruction.cpp:240 > + else if (m_isXSL) > + static_cast<XSLStyleSheet*>(m_sheet.get())->parseString(sheet, CSSStrictMode); This looks silly, XSLStyleSheet shouldn't be taking a CSSParserMode. > Source/WebCore/xml/XSLStyleSheet.h:74 > + virtual bool isLoading() const; Should add OVERRIDE while we are touching this.

Antti Koivisto

Comment 17 2012-04-11 13:14:19 PDT

(In reply to comment #16) > (From update of attachment 136708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136670&action=review > > > Source/WebCore/css/CSSStyleSheet.cpp:510 > > + m_childRuleCSSOMWrappers[index]->setParentStyleSheet(0); > > We're gonna need a null check here, since this particular wrapper may not have been instantiated. This bug was already in existing code. Fixed separately in http://trac.webkit.org/changeset/113898.

Antti Koivisto

Comment 18 2012-04-11 13:38:30 PDT

Created attachment 136741 [details] try to fix chromium build

WebKit Review Bot

Comment 19 2012-04-11 13:43:45 PDT

Attachment 136741 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.h:81: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSParser.cpp:1025: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 20 2012-04-11 16:11:30 PDT

Created attachment 136778 [details] fix a crashing test

WebKit Review Bot

Comment 21 2012-04-11 16:17:28 PDT

Attachment 136778 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.h:81: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/css/CSSParser.cpp:1025: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 22 2012-04-11 16:25:34 PDT

http://trac.webkit.org/changeset/113922

Note You need to log in before you can comment on or make changes to this bug.