Bug 83685

Summary: Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 53961    
Attachments:
Description Flags
Patch haraken: review+

Kent Tamura
Reported 2012-04-11 03:14:17 PDT
Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
Attachments
Patch (3.21 KB, patch)
2012-04-11 03:19 PDT, Kent Tamura 		haraken: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-04-11 03:19:58 PDT
Created attachment 136651 [details] Patch
Kentaro Hara
Comment 2 2012-04-11 04:09:29 PDT
Comment on attachment 136651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136651&action=review > Source/WebCore/ChangeLog:12 > + - leading adn trailing whitespace (.js and .css) Nit: *and* > Source/WebCore/make-file-arrays.py:59 > + leading_space = re.compile(r"^ ", re.MULTILINE) This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better. > Source/WebCore/make-file-arrays.py:60 > + trailing_space = re.compile(r" $", re.MULTILINE) Ditto. r"[ \t]+$" might be better. > Source/WebCore/make-file-arrays.py:75 > + print content Remove this
Kent Tamura
Comment 3 2012-04-12 23:33:30 PDT
Committed r114090: <http://trac.webkit.org/changeset/114090>
Kent Tamura
Comment 4 2012-04-12 23:34:36 PDT
(In reply to comment #2) > > Source/WebCore/ChangeLog:12 > > + - leading adn trailing whitespace (.js and .css) > > Nit: *and* Fixed. > > Source/WebCore/make-file-arrays.py:59 > > + leading_space = re.compile(r"^ ", re.MULTILINE) > > This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better. Fixed. > > Source/WebCore/make-file-arrays.py:60 > > + trailing_space = re.compile(r" $", re.MULTILINE) > > Ditto. r"[ \t]+$" might be better. Fixed. > > Source/WebCore/make-file-arrays.py:75 > > + print content > > Remove this Removed.
Note You need to log in before you can comment on or make changes to this bug.