Bug 85214

Summary: Add absoluteValue method for LayoutUnits to allow overloading abs()
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, jchaffraix
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-04-30 11:16:03 PDT
Since we can't overload std::abs() directly, adding an inline absoluteValue method instead.
Attachments
Patch (5.83 KB, patch)
2012-04-30 11:23 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-30 11:23:31 PDT
Created attachment 139485 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-30 12:03:35 PDT
Comment on attachment 139485 [details] Patch Darin Adler is a better reviewer for this than I am. But this is OK for me. I'd like you to wait a few hours and see if you can get him to comment as well though.
Eric Seidel (no email)
Comment 3 2012-04-30 12:04:07 PDT
The reason why I suggest Darin, is that he might have a clever suggestion for your std::abs() problem other than this one.
Levi Weintraub
Comment 4 2012-04-30 12:05:24 PDT
(In reply to comment #3) > The reason why I suggest Darin, is that he might have a clever suggestion for your std::abs() problem other than this one. Deal! I'll wait till near EOD PST.
Levi Weintraub
Comment 5 2012-04-30 16:37:51 PDT
(In reply to comment #4) > (In reply to comment #3) > > The reason why I suggest Darin, is that he might have a clever suggestion for your std::abs() problem other than this one. > > Deal! I'll wait till near EOD PST. Unless there's argument, I'll move forward on landing this.
Levi Weintraub
Comment 6 2012-04-30 17:05:43 PDT
Committed r115691: <http://trac.webkit.org/changeset/115691>
Levi Weintraub
Comment 7 2012-05-01 11:56:10 PDT
Comment on attachment 139485 [details] Patch Clearing flags
Darin Adler
Comment 8 2012-05-02 12:24:08 PDT
Comment on attachment 139485 [details] Patch Only thing I might have done differently would have been to overload it for int and FractionalLayoutUnit from the start rather than defining it as a function that takes LayoutUnit.
Note You need to log in before you can comment on or make changes to this bug.