Bug 89436

Summary:

[Qt] New fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html introduced in r120624 fails on ICU platforms

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Marcelo Lira <marcelo.lira>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

ap, marcelo.lira, mitz, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

87008, 87041

Attachments:

Description	Flags
Patch	ap: review-, ap: commit-queue-

Csaba Osztrogonác

Reported 2012-06-18 23:48:10 PDT

fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html introduced in http://trac.webkit.org/changeset/120624 and fails on Qt5 which is ICU platform. (But pass on non-ICU Qt4) --- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/fast/text/line-breaks-after-ideographic-comma-or-full-stop-2-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/fast/text/line-breaks-after-ideographic-comma-or-full-stop-2-actual.txt @@ -1,4 +1,4 @@ This tests that a line break is prohibited between an ideographic comma and a right corner bracket. ăăăă -PASS +FAIL

Attachments
Patch (1.63 KB, patch) 2012-09-21 09:30 PDT, Marcelo Lira	ap: review- ap: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2012-06-18 23:54:49 PDT

I skipped it on Qt5 which is ICU platform - http://trac.webkit.org/changeset/120682/trunk/LayoutTests/platform/qt-5.0/Skipped

Marcelo Lira

Comment 2 2012-09-21 09:30:05 PDT

Created attachment 165145 [details] Patch

Alexey Proskuryakov

Comment 3 2012-09-21 09:52:13 PDT

Comment on attachment 165145 [details] Patch EWS says that the patch doesn't apply, please update your checkout, and make a new one.

Csaba Osztrogonác

Comment 4 2012-09-22 00:31:21 PDT

I tested it and it still fails on WK1 and WK2 too. I don't know how can you make it pass. :)

Marcelo Lira

Comment 5 2012-09-25 14:32:54 PDT

(In reply to comment #4) > I tested it and it still fails on WK1 and WK2 too. > I don't know how can you make it pass. :) Sorry, it was a mistake. ><

Jocelyn Turcotte

Comment 6 2014-02-03 03:21:18 PST

=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.

Note You need to log in before you can comment on or make changes to this bug.