Bug 92895

Summary: [Qt][WK2] There's no way to test the gesture tap on WTR
Product: WebKit Reporter: Hugo Parente Lima <hugo.lima>
Component: WebKit QtAssignee: Hugo Parente Lima <hugo.lima>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, jesus, kenneth, luciano.wolf, menard, tonikitoo, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66173, 91012    
Attachments:
Description Flags
Patch none

Hugo Parente Lima
Reported 2012-08-01 12:03:13 PDT
There's no way to test the gesture tap on WTR because the code on QtWebPageEventHandler::doneWithTouchEvent relies on a instance of QtViewportHandler and such instance doesn't exist because WTR runs on "desktop mode".
Attachments
Patch (5.29 KB, patch)
2012-08-02 15:36 PDT, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hugo Parente Lima
Comment 1 2012-08-02 15:36:01 PDT
Created attachment 156184 [details] Patch
Andras Becsi
Comment 2 2012-08-03 08:47:12 PDT
As far as I remember componentComplete is only triggered in QML, so in C++ unless WTR creates a WebView component dinamically this codepath won't be triggered so the viewport handler will still be null there, but I might be wrong.
WebKit Review Bot
Comment 3 2012-08-03 10:21:34 PDT
Comment on attachment 156184 [details] Patch Clearing flags on attachment: 156184 Committed r124625: <http://trac.webkit.org/changeset/124625>
WebKit Review Bot
Comment 4 2012-08-03 10:21:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.