Bug 94309

Summary: DFG is still too pessimistic about what constitutes a side-effect on array accesses
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 91933    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2012-08-17 01:07:03 PDT
The change to introduce PutByValSafe, and the change to eliminate the use of array predictions in selecting what kind of access to use, was not completely propagated to the structure check hoister or the CFA.
Attachments
the patch (3.74 KB, patch)
2012-08-17 01:27 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-08-17 01:27:27 PDT
Created attachment 159044 [details] the patch
Geoffrey Garen
Comment 2 2012-08-17 14:16:08 PDT
Comment on attachment 159044 [details] the patch r=me
Filip Pizlo
Comment 3 2012-08-17 17:57:30 PDT
Landed in http://trac.webkit.org/changeset/125959
Note You need to log in before you can comment on or make changes to this bug.