Bug 95013

Summary: Array type checks and storage accesses should be uniformly represented and available to CSE
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mhahnenberg, msaboff, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 95014    
Bug Blocks: 91933    
Attachments:
Description Flags
work in progress
none
work in progress
none
the patch
none
the patch
none
the patch oliver: review+

Filip Pizlo
Reported 2012-08-25 15:48:12 PDT
Patch forthcoming.
Attachments
work in progress (56.88 KB, patch)
2012-08-25 16:59 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
work in progress (62.50 KB, patch)
2012-08-26 00:06 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (74.86 KB, patch)
2012-08-26 11:40 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (74.83 KB, patch)
2012-08-26 11:57 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (75.17 KB, patch)
2012-08-26 12:15 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-08-25 16:59:28 PDT
Created attachment 160580 [details] work in progress
Filip Pizlo
Comment 2 2012-08-26 00:06:48 PDT
Created attachment 160593 [details] work in progress It runs simple things.
Filip Pizlo
Comment 3 2012-08-26 11:40:11 PDT
Created attachment 160607 [details] the patch
WebKit Review Bot
Comment 4 2012-08-26 11:42:51 PDT
Attachment 160607 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGArrayMode.h:66: The parameter name "structure" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGGraph.h:79: The parameter name "globalData" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGGraph.h:79: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 5 2012-08-26 11:57:28 PDT
Created attachment 160608 [details] the patch Fixed style.
Filip Pizlo
Comment 6 2012-08-26 12:15:38 PDT
Created attachment 160611 [details] the patch Minor build fix.
Oliver Hunt
Comment 7 2012-08-26 12:48:39 PDT
Comment on attachment 160611 [details] the patch r=me
Filip Pizlo
Comment 8 2012-08-26 15:35:36 PDT
Landed in http://trac.webkit.org/changeset/126715
Note You need to log in before you can comment on or make changes to this bug.