Bug 95730

Summary: [Qt][Win] Fix IDL dependency generation correctly
Product: WebKit Reporter: Jonathan Liu <net147>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: abecsi, ap, hausmann, ossy, vestbo, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 76773    
Attachments:
Description Flags
Patch none

Jonathan Liu
Reported 2012-09-04 04:13:27 PDT
IDL dependency generation is still not working after https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces added after the filename in an echo command end up being added to the file (e.g. "echo test>> test.txt " would add a space at the end of the line in test.txt).
Attachments
Patch (1.82 KB, patch)
2012-09-04 04:22 PDT, Jonathan Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Liu
Comment 1 2012-09-04 04:22:28 PDT
Created attachment 162006 [details] Patch
Csaba Osztrogonác
Comment 2 2012-09-04 04:36:54 PDT
The trailing whitespace is ugly at the end of the command. But why does it cause problem for you? Windows simple ignores these trailing whitespaces.
Jonathan Liu
Comment 3 2012-09-04 04:38:31 PDT
It doesn't ignore the trailing whitespace at least on Windows 7. Try it from a command prompt: type "echo test>> test.txt " (without the quotes and with a space at the end) and press enter. Open test.txt and you will see a trailing space after "test".
Csaba Osztrogonác
Comment 4 2012-09-04 04:43:36 PDT
(In reply to comment #3) > It doesn't ignore the trailing whitespace at least on Windows 7. Try it from a command prompt: type "echo test>> test.txt " (without the quotes and with a space at the end) and press enter. Open test.txt and you will see a trailing space after "test". OMG, you're right, same result on Win XP, crazy Windows' cmd.exe :)
Csaba Osztrogonác
Comment 5 2012-09-04 04:45:18 PDT
Comment on attachment 162006 [details] Patch r=me
Jonathan Liu
Comment 6 2012-09-04 04:45:36 PDT
An alternative syntax for echo to a file is: echo>>test.txt blah blah blah That's why it adds the space.
WebKit Review Bot
Comment 7 2012-09-04 06:48:28 PDT
Comment on attachment 162006 [details] Patch Clearing flags on attachment: 162006 Committed r127467: <http://trac.webkit.org/changeset/127467>
WebKit Review Bot
Comment 8 2012-09-04 06:48:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.