Bug 95903

Summary: XMLHttpRequest.open does not need custom bindings
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: annevk, ap, eric, haraken, japhet, mitz, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95972    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-09-05 15:31:34 PDT
XMLHttpRequest.open does not need custom bindings
Attachments
Patch (9.87 KB, patch)
2012-09-05 15:33 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-05 15:33:11 PDT
Created attachment 162351 [details] Patch
Kentaro Hara
Comment 2 2012-09-05 16:35:57 PDT
Comment on attachment 162351 [details] Patch Looks OK
WebKit Review Bot
Comment 3 2012-09-06 02:38:02 PDT
Comment on attachment 162351 [details] Patch Clearing flags on attachment: 162351 Committed r127712: <http://trac.webkit.org/changeset/127712>
WebKit Review Bot
Comment 4 2012-09-06 02:38:06 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2012-09-06 04:15:34 PDT
(In reply to comment #3) > (From update of attachment 162351 [details]) > Clearing flags on attachment: 162351 > > Committed r127712: <http://trac.webkit.org/changeset/127712> It caused a regression - https://bugs.webkit.org/show_bug.cgi?id=95972 Could you check it, please?
mitz
Comment 6 2012-09-06 10:12:35 PDT
(In reply to comment #3) > (From update of attachment 162351 [details]) > Clearing flags on attachment: 162351 > > Committed r127712: <http://trac.webkit.org/changeset/127712> I have reverted this change in <http://trac.webkit.org/r127751>, so I am reopening the bug, even though it is likely based on a false premise (“[Optional] works the way XMLHttpRequest expects”).
Adam Barth
Comment 7 2012-09-06 10:40:34 PDT
We just need to use TreatUndefinedAs and TreatNullAs appropriately.
Adam Barth
Comment 8 2012-09-06 10:51:54 PDT
Thanks for reverting the patch.
Note You need to log in before you can comment on or make changes to this bug.