Bug 98548

Created attachment 168026 [details] Patch Added a pair of CSS Exclusions shape-inside ref-tests for regular polygons with 8 and 16 sides. Also made some small revisions to the supporting code, simple-polyon.js, and the existing simple polygon tests, to localize the conversion from float to layout coordinates and to cleanup the extraneous vertices argument int the createPolygonShapeInsideTestCase functions.

Comment on attachment 168026 [details] Patch Attachment 168026 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14260099 New failing tests: fast/exclusions/shape-inside/shape-inside-regular-polygon16.html fast/exclusions/shape-inside/shape-inside-regular-polygon8.html

(In reply to comment #2) > (From update of attachment 168026 [details]) > Attachment 168026 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/14260099 > > New failing tests: > fast/exclusions/shape-inside/shape-inside-regular-polygon16.html > fast/exclusions/shape-inside/shape-inside-regular-polygon8.html It seems we need to generate pixel test results for these. Otherwise the patch looks okay to me.

Created attachment 168074 [details] Patch Detect subpixel layout support hand handle rounding the left edge of line segment intervals by actually rounding in that case.

Comment on attachment 168074 [details] Patch Attachment 168074 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14258397 New failing tests: fast/exclusions/shape-inside/shape-inside-regular-polygon8.html

Created attachment 168232 [details] Patch Revised simple-polygon.js subpixelRound() function to more closely match FractionLayout(floatValue).round().

Comment on attachment 168232 [details] Patch Attachment 168232 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14264015 New failing tests: fast/exclusions/shape-inside/shape-inside-regular-polygon8.html

Created attachment 168280 [details] Patch After testing on a Chromium build, corrected two problems: regular polygons were not always exactly symmetric vis the Y axis, shape-inside-regular-polygon8-expected.html was not initializing hasSubpixelSupport.

Comment on attachment 168280 [details] Patch Rejecting attachment 168280 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/14287113

Comment on attachment 168280 [details] Patch Lets try it again.

Comment on attachment 168280 [details] Patch Rejecting attachment 168280 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/14388301

Created attachment 169043 [details] Patch Advanced ChangeLog entry date by 1000 years.

Comment on attachment 169043 [details] Patch Rejecting attachment 169043 [details] from commit-queue. giles_joplin@yahoo.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

(In reply to comment #12) > Created an attachment (id=169043) [details] > Patch > > Advanced ChangeLog entry date by 1000 years. Sorry. That's 2000 years. Hard to keep the millennia straight.

Created attachment 169044 [details] Patch Resubmitting after accidentally setting the commit flag myself.

Comment on attachment 169044 [details] Patch Clearing flags on attachment: 169044 Committed r131610: <http://trac.webkit.org/changeset/131610>

All reviewed patches have been landed. Closing bug.