RESOLVED FIXED173644
Use TilesBacking for iframes when async frame scrolling is enabled
https://bugs.webkit.org/show_bug.cgi?id=173644
Summary Use TilesBacking for iframes when async frame scrolling is enabled
Frédéric Wang Nélar
Reported 2017-06-21 04:36:26 PDT
Currently tiles backing are only used for the main frame.
Attachments
Patch (WIP) (9.02 KB, patch)
2017-06-21 04:38 PDT, Frédéric Wang Nélar
buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan (1.01 MB, application/zip)
2017-06-21 05:37 PDT, Build Bot
no flags
Archive of layout-test-results from ews112 for mac-elcapitan (1.76 MB, application/zip)
2017-06-21 05:57 PDT, Build Bot
no flags
Archive of layout-test-results from ews122 for ios-simulator-wk2 (916.55 KB, application/zip)
2017-06-21 06:04 PDT, Build Bot
no flags
WIP Patch (14.30 KB, patch)
2017-06-21 07:04 PDT, Frédéric Wang Nélar
no flags
Patch (25.60 KB, patch)
2017-06-21 08:59 PDT, Frédéric Wang Nélar
simon.fraser: review+
Patch for landing (26.85 KB, patch)
2017-09-05 04:42 PDT, Frédéric Wang Nélar
no flags
Frédéric Wang Nélar
Comment 1 2017-06-21 04:38:29 PDT
Created attachment 313506 [details] Patch (WIP)
Build Bot
Comment 2 2017-06-21 05:37:56 PDT
Comment on attachment 313506 [details] Patch (WIP) Attachment 313506 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3971677 New failing tests: tiled-drawing-scrollable-iframe.html
Build Bot
Comment 3 2017-06-21 05:37:57 PDT
Created attachment 313507 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 4 2017-06-21 05:57:55 PDT
Comment on attachment 313506 [details] Patch (WIP) Attachment 313506 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3971694 New failing tests: tiled-drawing-scrollable-iframe.html
Build Bot
Comment 5 2017-06-21 05:57:56 PDT
Created attachment 313509 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-06-21 06:04:15 PDT
Comment on attachment 313506 [details] Patch (WIP) Attachment 313506 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3971702 New failing tests: tiled-drawing-scrollable-iframe.html
Build Bot
Comment 7 2017-06-21 06:04:16 PDT
Created attachment 313510 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Frédéric Wang Nélar
Comment 8 2017-06-21 07:04:31 PDT
Created attachment 313516 [details] WIP Patch
Frédéric Wang Nélar
Comment 9 2017-06-21 08:59:40 PDT
Frédéric Wang Nélar
Comment 10 2017-06-21 09:01:50 PDT
Note: My patches for bug 171667 still work with that change. However, some bugs appear with the background color of the iframes or the painting of scrollbars. Probably this can be handled in follow-up bugs though.
Radar WebKit Bug Importer
Comment 11 2017-09-01 14:22:43 PDT
Frédéric Wang Nélar
Comment 12 2017-09-05 04:42:43 PDT
Created attachment 319892 [details] Patch for landing Rebasing...
WebKit Commit Bot
Comment 13 2017-09-05 06:38:14 PDT
Comment on attachment 319892 [details] Patch for landing Clearing flags on attachment: 319892 Committed r221615: <http://trac.webkit.org/changeset/221615>
Frédéric Wang Nélar
Comment 14 2017-09-15 09:52:59 PDT
(In reply to Frédéric Wang (:fredw) from comment #10) > Note: My patches for bug 171667 still work with that change. However, some > bugs appear with the background color of the iframes or the painting of > scrollbars. Probably this can be handled in follow-up bugs though. These issues are handled in bug 176261 and bug 177009.
Note You need to log in before you can comment on or make changes to this bug.