WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237581
prepare-ChangeLog does not include Swift functions which contain local vars
https://bugs.webkit.org/show_bug.cgi?id=237581
Summary
prepare-ChangeLog does not include Swift functions which contain local vars
mmokary
Reported
2022-03-07 21:29:08 PST
prepare-ChangeLog does not include Swift functions which contain local vars Once the parser matches a variable or function it loses reference to any current function it was tracking. So when a function defines a local var, the var is matched and the containing function is lost. For example: 1 class SomeClass { 2 func aClassMethod() { 3 var local: Local 4 } 5 } Changes to aClassMethod will never cause (SomeClass.aClassMethod) in the ChangeLog because the range of [3, 3, local] is recorded instead.
Attachments
Ignore nested function and var matches
(4.32 KB, patch)
2022-03-07 22:30 PST
,
mmokary
ddkilzer
: review+
ddkilzer
: commit-queue-
Details
Formatted Diff
Diff
Patch for landing sans ChangeLog
(4.30 KB, patch)
2022-07-13 18:07 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-03-07 21:33:17 PST
<
rdar://problem/89948275
>
mmokary
Comment 2
2022-03-07 22:30:49 PST
Created
attachment 454073
[details]
Ignore nested function and var matches
David Kilzer (:ddkilzer)
Comment 3
2022-07-13 16:07:47 PDT
Comment on
attachment 454073
[details]
Ignore nested function and var matches r=me
David Kilzer (:ddkilzer)
Comment 4
2022-07-13 17:54:12 PDT
OH. This patch is old enough that it still includes a ChangeLog file, but it's not supposed to include that anymore.
David Kilzer (:ddkilzer)
Comment 5
2022-07-13 18:07:23 PDT
Created
attachment 460877
[details]
Patch for landing sans ChangeLog
David Kilzer (:ddkilzer)
Comment 6
2022-07-13 18:16:32 PDT
Comment on
attachment 460877
[details]
Patch for landing sans ChangeLog I seem to have broke the commit queue script with this patch. :|
David Kilzer (:ddkilzer)
Comment 7
2022-07-13 20:13:41 PDT
Tracking a fix for the commit queue:
Bug 242735
Submitted: Commit queue fails to land patch with changes to prepare-ChangeLog script
David Kilzer (:ddkilzer)
Comment 8
2022-07-16 09:45:45 PDT
Waiting for the commit queue bot(s) to be updated/restarted to pick up the fix from
Bug 242735
before this patch can land.
David Kilzer (:ddkilzer)
Comment 9
2022-07-18 11:14:45 PDT
(In reply to David Kilzer (:ddkilzer) from
comment #8
)
> Waiting for the commit queue bot(s) to be updated/restarted to pick up the > fix from
Bug 242735
before this patch can land.
UGH. Still getting the same error message as before:
> File "/var/buildbot/OpenSource/Tools/CISupport/ews-build/steps.py", line 4919, in _files > match = re.search(self.RE_CHANGELOG, line) > File "/usr/lib64/python3.6/re.py", line 182, in search > return _compile(pattern, flags).search(string)
builtins.TypeError: cannot use a string pattern on a bytes-like object I'm not sure how to fix that.
EWS
Comment 10
2022-07-18 12:28:06 PDT
Committed
252573@main
(8e82c35b8f05): <
https://commits.webkit.org/252573@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 460877
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug