RESOLVED FIXED 281710
Convert basic shapes types to strongly typed CSS/Style values 
https://bugs.webkit.org/show_bug.cgi?id=281710
Summary Convert basic shapes types to strongly typed CSS/Style values
Sam Weinig
Reported 2024-10-17 18:15:07 PDT
Convert basic shapes types to strongly typed CSS/Style values. A bit more complicated than gradient, will require bringing in blending support.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2024-10-18 19:08:14 PDT
Pull request: https://github.com/WebKit/WebKit/pull/35472
Radar WebKit Bug Importer
Comment 2 2024-10-24 18:16:14 PDT
<rdar://problem/138601093>
EWS
Comment 3 2024-10-25 11:31:30 PDT
Committed 285708@main (4692eacc698b): <https://commits.webkit.org/285708@main> Reviewed commits have been landed. Closing PR #35472 and removing active labels.
Jonathan Bedard
Comment 4 2024-10-25 21:09:06 PDT
Reopened Bugzilla. REGRESSION (285708@main) Broke the macOS debug builds, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=282127.
Alex Christensen
Comment 5 2024-10-25 21:55:06 PDT
Could you please include this diff when re-landing? It fixes TestWebKitAPI.IPCTestingAPI.SerializedTypeInfo: diff --git a/Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in b/Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in index 693f675b06f6..e2e34bad5904 100644 --- a/Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in +++ b/Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in @@ -3127,15 +3127,15 @@ using WebCore::Style::LengthPercentagePointAll = WebCore::Style::Point<WebCore:: using WebCore::Style::LengthPercentagePointNonnegative = WebCore::Style::Point<WebCore::Style::LengthPercentageNonnegative>; [CustomHeader, Nested] struct WebCore::Style::CommaSeparatedVector<WebCore::Style::LengthPercentagePointAll> { - WebCore::Style::CommaSeparatedVector<WebCore::Style::LengthPercentagePointAll>::Vector value; + Vector<WebCore::Style::LengthPercentagePointAll> value; }; [CustomHeader, Nested] struct WebCore::Style::CommaSeparatedVector<WebCore::Style::LengthPercentagePointNonnegative> { - WebCore::Style::CommaSeparatedVector<WebCore::Style::LengthPercentagePointNonnegative>::Vector value; + Vector<WebCore::Style::LengthPercentagePointNonnegative> value; }; using WebCore::Style::ShapeCommand = std::variant<WebCore::Style::MoveCommand, WebCore::Style::LineCommand, WebCore::Style::HLineCommand, WebCore::Style::VLineCommand, WebCore::Style::CurveCommand, WebCore::Style::SmoothCommand, WebCore::Style::ArcCommand, WebCore::Style::CloseCommand>; [CustomHeader, Nested] struct WebCore::Style::CommaSeparatedVector<WebCore::Style::ShapeCommand> { - WebCore::Style::CommaSeparatedVector<WebCore::Style::ShapeCommand>::Vector value; + Vector<WebCore::Style::ShapeCommand> value; }; header: <WebCore/StylePosition.h> @@ -3345,6 +3345,7 @@ using WebCore::Style::CloseCommand = WebCore::Style::Constant<WebCore::CSSValueC std::variant<WebCore::Style::Large, WebCore::Style::Small> arcSize; WebCore::Style::Angle<WebCore::CSS::All> rotation; }; +using WebCore::Style::LengthPercentageSizeAll = WebCore::Style::Size<WebCore::Style::LengthPercentageAll> header: <WebCore/StyleBorderRadius.h> [CustomHeader, Nested] struct WebCore::Style::BorderRadius { @@ -7518,6 +7519,8 @@ header: <WebCore/GraphicsContextState.h> WebCore::GraphicsContextState::Purpose m_purpose; }; +enum class WebCore::WindRule : bool + [AdditionalEncoder=StreamConnectionEncoder] struct WebCore::SourceBrushLogicalGradient { std::variant<Ref<WebCore::Gradient>, WebCore::RenderingResourceIdentifier> serializableGradient(); WebCore::AffineTransform spaceTransform;
Sam Weinig
Comment 6 2024-10-27 09:20:35 PDT
Pull request: https://github.com/WebKit/WebKit/pull/35773
EWS
Comment 7 2024-10-31 10:26:02 PDT
Committed 285966@main (060102d7428f): <https://commits.webkit.org/285966@main> Reviewed commits have been landed. Closing PR #35773 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.